From 926d2e4cf2d9c0e9cbad0d11e81d95bb500d653b Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Thu, 7 Mar 2024 13:10:23 +1100 Subject: [PATCH] dns_db_setloop called at wrong place on wrong db In cache_create_db, dns_db_setloop should be called on the newly created db only if the database creation succeeded. --- lib/dns/cache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/dns/cache.c b/lib/dns/cache.c index d425316cc46..902ae732e99 100644 --- a/lib/dns/cache.c +++ b/lib/dns/cache.c @@ -101,10 +101,9 @@ cache_create_db(dns_cache_t *cache, dns_db_t **db) { if (result == ISC_R_SUCCESS) { dns_db_setservestalettl(*db, cache->serve_stale_ttl); dns_db_setservestalerefresh(*db, cache->serve_stale_refresh); + dns_db_setloop(*db, cache->loop); } - dns_db_setloop(cache->db, cache->loop); - return (result); } -- 2.47.3