From 93185432df2190ac08a7ee73dfc09010c5a3a84a Mon Sep 17 00:00:00 2001 From: Federico Caselli Date: Wed, 22 Nov 2023 22:04:03 +0100 Subject: [PATCH] Fix pre-ping regression in old PyMySQL versions. Fixed regression introduced by the fix in ticket :ticket:`10492` when using pool pre-ping with PyMySQL version older than 1.0. Fixes: #10650 Change-Id: Ic0744c8b6f91cc39868e31c3bfddb8df20c7dfbb --- doc/build/changelog/unreleased_14/10650.rst | 7 +++++++ lib/sqlalchemy/dialects/mysql/pymysql.py | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 doc/build/changelog/unreleased_14/10650.rst diff --git a/doc/build/changelog/unreleased_14/10650.rst b/doc/build/changelog/unreleased_14/10650.rst new file mode 100644 index 0000000000..dce6b4c75a --- /dev/null +++ b/doc/build/changelog/unreleased_14/10650.rst @@ -0,0 +1,7 @@ +.. change:: + :tags: bug, mysql + :tickets: 10650 + :versions: 2.0.24 + + Fixed regression introduced by the fix in ticket :ticket:`10492` when using + pool pre-ping with PyMySQL version older than 1.0. diff --git a/lib/sqlalchemy/dialects/mysql/pymysql.py b/lib/sqlalchemy/dialects/mysql/pymysql.py index 6567202a45..ddb99542f8 100644 --- a/lib/sqlalchemy/dialects/mysql/pymysql.py +++ b/lib/sqlalchemy/dialects/mysql/pymysql.py @@ -86,7 +86,9 @@ class MySQLDialect_pymysql(MySQLDialect_mysqldb): """ # noqa: E501 try: - Connection = __import__("pymysql.connections").Connection + Connection = __import__( + "pymysql.connections" + ).connections.Connection except (ImportError, AttributeError): return True else: -- 2.47.2