From 932af62eade70714ca7351738b936123c5345fd0 Mon Sep 17 00:00:00 2001 From: David Mulder Date: Tue, 3 Nov 2020 13:14:34 -0700 Subject: [PATCH] gpo: Test Group Policy VGP Sudo Rights Signed-off-by: David Mulder Reviewed-by: Jeremy Allison --- python/samba/tests/gpo.py | 68 +++++++++++++++++++++++++++++++++ python/samba/vgp_sudoers_ext.py | 22 +++++++++++ selftest/knownfail.d/gpo | 1 + 3 files changed, 91 insertions(+) create mode 100644 python/samba/vgp_sudoers_ext.py create mode 100644 selftest/knownfail.d/gpo diff --git a/python/samba/tests/gpo.py b/python/samba/tests/gpo.py index 115b71ac61d..a0dce8d96d7 100644 --- a/python/samba/tests/gpo.py +++ b/python/samba/tests/gpo.py @@ -27,6 +27,7 @@ from tempfile import NamedTemporaryFile, TemporaryDirectory from samba.gp_sec_ext import gp_krb_ext, gp_access_ext from samba.gp_scripts_ext import gp_scripts_ext from samba.gp_sudoers_ext import gp_sudoers_ext +from samba.vgp_sudoers_ext import vgp_sudoers_ext from samba.gpclass import gp_inf_ext from samba.gp_smb_conf_ext import gp_smb_conf_ext import logging @@ -37,6 +38,7 @@ from samba.dcerpc import preg from samba.ndr import ndr_pack import codecs from shutil import copyfile +import xml.etree.ElementTree as etree realm = os.environ.get('REALM') policies = realm + '/POLICIES' @@ -440,6 +442,72 @@ class GPOTests(tests.TestCase): # Unstage the Registry.pol file unstage_file(reg_pol) + def test_vgp_sudoers(self): + local_path = self.lp.cache_path('gpo_cache') + guid = '{31B2F340-016D-11D2-945F-00C04FB984F9}' + manifest = os.path.join(local_path, policies, guid, 'MACHINE', + 'VGP/VTLA/SUDO/SUDOERSCONFIGURATION/MANIFEST.XML') + logger = logging.getLogger('gpo_tests') + cache_dir = self.lp.get('cache directory') + store = GPOStorage(os.path.join(cache_dir, 'gpo.tdb')) + + machine_creds = Credentials() + machine_creds.guess(self.lp) + machine_creds.set_machine_account() + + # Initialize the group policy extension + ext = vgp_sudoers_ext(logger, self.lp, machine_creds, store) + + ads = gpo.ADS_STRUCT(self.server, self.lp, machine_creds) + if ads.connect(): + gpos = ads.get_gpo_list(machine_creds.get_username()) + + # Stage the manifest.xml file with test data + stage = etree.Element('vgppolicy') + policysetting = etree.Element('policysetting') + stage.append(policysetting) + version = etree.Element('version') + version.text = '1' + policysetting.append(version) + data = etree.Element('data') + sudoers_entry = etree.Element('sudoers_entry') + command = etree.Element('command') + command.text = 'ALL' + sudoers_entry.append(command) + user = etree.Element('user') + user.text = 'ALL' + sudoers_entry.append(user) + principal_list = etree.Element('listelement') + principal = etree.Element('principal') + principal.text = 'fakeu' + principal.attrib['type'] = 'user' + principal_list.append(principal) + sudoers_entry.append(principal_list) + data.append(sudoers_entry) + policysetting.append(data) + ret = stage_file(manifest, etree.tostring(stage)) + self.assertTrue(ret, 'Could not create the target %s' % manifest) + + # Process all gpos, with temp output directory + data = 'fakeu ALL=(ALL) NOPASSWD: ALL' + with TemporaryDirectory() as dname: + ext.process_group_policy([], gpos, dname) + sudoers = os.listdir(dname) + self.assertEquals(len(sudoers), 1, 'The sudoer file was not created') + self.assertIn(data, + open(os.path.join(dname, sudoers[0]), 'r').read(), + 'The sudoers entry was not applied') + + # Remove policy + gp_db = store.get_gplog(machine_creds.get_username()) + del_gpos = get_deleted_gpos_list(gp_db, []) + ext.process_group_policy(del_gpos, []) + self.assertEquals(len(os.listdir(dname)), 0, + 'Unapply failed to cleanup scripts') + + # Unstage the Registry.pol file + unstage_file(manifest) + def test_gp_inf_ext_utf(self): logger = logging.getLogger('gpo_tests') cache_dir = self.lp.get('cache directory') diff --git a/python/samba/vgp_sudoers_ext.py b/python/samba/vgp_sudoers_ext.py new file mode 100644 index 00000000000..3b751538784 --- /dev/null +++ b/python/samba/vgp_sudoers_ext.py @@ -0,0 +1,22 @@ +# vgp_sudoers_ext samba gpo policy +# Copyright (C) David Mulder 2020 +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +from samba.gpclass import gp_xml_ext + +class vgp_sudoers_ext(gp_xml_ext): + def process_group_policy(self, deleted_gpo_list, changed_gpo_list, + sdir='/etc/sudoers.d'): + pass diff --git a/selftest/knownfail.d/gpo b/selftest/knownfail.d/gpo new file mode 100644 index 00000000000..4be23fb2004 --- /dev/null +++ b/selftest/knownfail.d/gpo @@ -0,0 +1 @@ +^samba.tests.gpo.samba.tests.gpo.GPOTests.test_vgp_sudoers -- 2.47.2