From 9452252dff94ff2cbcd33d3418c2b95ff74bdba5 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 24 Oct 2025 09:19:21 +0300 Subject: [PATCH] gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe() The devm_platform_ioremap_resource() function doesn't return NULL, it returns error pointers. Fix the checking to match. Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller") Signed-off-by: Dan Carpenter Reviewed-by: Michael Walle Link: https://lore.kernel.org/r/aPsaaf0h343Ba7c1@stanley.mountain Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-qixis-fpga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c index 54c2c76822d56..6e67f43ac0bdd 100644 --- a/drivers/gpio/gpio-qixis-fpga.c +++ b/drivers/gpio/gpio-qixis-fpga.c @@ -56,8 +56,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *pdev) * create our own from the MMIO space. */ reg = devm_platform_ioremap_resource(pdev, 0); - if (!reg) - return -ENODEV; + if (IS_ERR(reg)) + return PTR_ERR(reg); regmap = devm_regmap_init_mmio(&pdev->dev, reg, ®map_config_8r_8v); if (!regmap) -- 2.47.3