From 94c227de0a59e21b505cfd2dd7cdcf9e5360fb74 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Fabiano=20Fid=C3=AAncio?= <fidencio@redhat.com>
Date: Thu, 19 Dec 2019 10:12:56 +0100
Subject: [PATCH] util: Don't check the output of virGetUserCacheDirectory()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/util/virlog.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virlog.c b/src/util/virlog.c
index 10639d7328..6bae56e2e3 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -180,8 +180,7 @@ virLogSetDefaultOutputToFile(const char *binary, bool privileged)
         virLogDefaultOutput = g_strdup_printf("%d:file:%s/log/libvirt/%s.log",
                                               virLogDefaultPriority, LOCALSTATEDIR, binary);
     } else {
-        if (!(logdir = virGetUserCacheDirectory()))
-            return -1;
+        logdir = virGetUserCacheDirectory();
 
         old_umask = umask(077);
         if (virFileMakePath(logdir) < 0) {
-- 
2.47.2