From 94c736e48e176b18c87cc97e3d2b4feea2a47a90 Mon Sep 17 00:00:00 2001 From: Rico Tzschichholz Date: Mon, 29 Jan 2018 17:38:19 +0100 Subject: [PATCH] girparser: Don't accept methods as property-accessor which throw errors This should be considered a temporary fix. https://bugzilla.gnome.org/show_bug.cgi?id=792998 --- vala/valagirparser.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vala/valagirparser.vala b/vala/valagirparser.vala index 387db6027..140456c9d 100644 --- a/vala/valagirparser.vala +++ b/vala/valagirparser.vala @@ -1005,7 +1005,7 @@ public class Vala.GirParser : CodeVisitor { // ensure getter vfunc if the property is abstract if (m != null) { getter.process (parser); - if (m.return_type is VoidType || m.get_parameters().size != 0) { + if (m.return_type is VoidType || m.get_parameters().size != 0 || m.get_error_types ().size > 0) { prop.set_attribute ("NoAccessorMethod", true); } else { if (getter.name == name) { @@ -1032,7 +1032,7 @@ public class Vala.GirParser : CodeVisitor { // ensure setter vfunc if the property is abstract if (m != null) { setter.process (parser); - if (!(m.return_type is VoidType || m.return_type is BooleanType) || m.get_parameters().size != 1) { + if (!(m.return_type is VoidType || m.return_type is BooleanType) || m.get_parameters ().size != 1 || m.get_error_types ().size > 0) { prop.set_attribute ("NoAccessorMethod", true); prop.set_attribute ("ConcreteAccessor", false); } else { -- 2.47.2