From 94f26f01bdff168cf13fbe9caa85b0c4031ff541 Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 11 Jun 2020 10:34:21 +0200
Subject: [PATCH] remoteDispatchDomainMigratePrepare*: Don't pass uninitialized
 variable to VIR_FREE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

'uri_out' may be passed to VIR_FREE uninitialized if 'conn' is NULL.
Unfortunately the compiler isn't able to detect this problem when
VIR_FREE is implemented using g_clear_pointer. Initialize the variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com
---
 src/remote/remote_daemon_dispatch.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index 6f67d2fb30..831e7d165c 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -3030,7 +3030,7 @@ remoteDispatchDomainMigratePrepare(virNetServerPtr server G_GNUC_UNUSED,
     char *cookie = NULL;
     int cookielen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -3082,7 +3082,7 @@ remoteDispatchDomainMigratePrepare2(virNetServerPtr server G_GNUC_UNUSED,
     char *cookie = NULL;
     int cookielen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -4789,7 +4789,7 @@ remoteDispatchDomainMigratePrepare3(virNetServerPtr server G_GNUC_UNUSED,
     char *cookieout = NULL;
     int cookieoutlen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -5584,7 +5584,7 @@ remoteDispatchDomainMigratePrepare3Params(virNetServerPtr server G_GNUC_UNUSED,
     int nparams = 0;
     char *cookieout = NULL;
     int cookieoutlen = 0;
-    char **uri_out;
+    char **uri_out = NULL;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
 
-- 
2.47.2