From 95542a6ec4b350c653b793b7c36a8210b0e9a89d Mon Sep 17 00:00:00 2001 From: Kyrylo Tkachov Date: Wed, 24 May 2023 09:33:04 +0100 Subject: [PATCH] arm: PR target/109939 Correct signedness of return type of __ssat intrinsics As the PR says we shouldn't be using qualifier_unsigned for the return type of the __ssat intrinsics. UNSIGNED_SAT_BINOP_UNSIGNED_IMM_QUALIFIERS already exists for that. This was just a thinko. This patch fixes this and the warning with -Wconversion goes away. Bootstrapped and tested on arm-none-linux-gnueabihf. gcc/ChangeLog: PR target/109939 * config/arm/arm-builtins.cc (SAT_BINOP_UNSIGNED_IMM_QUALIFIERS): Use qualifier_none for the return operand. gcc/testsuite/ChangeLog: PR target/109939 * gcc.target/arm/pr109939.c: New test. --- gcc/config/arm/arm-builtins.cc | 2 +- gcc/testsuite/gcc.target/arm/pr109939.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/arm/pr109939.c diff --git a/gcc/config/arm/arm-builtins.cc b/gcc/config/arm/arm-builtins.cc index d0c57409b4c2..36365e40a5b8 100644 --- a/gcc/config/arm/arm-builtins.cc +++ b/gcc/config/arm/arm-builtins.cc @@ -97,7 +97,7 @@ arm_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] /* T (T, unsigned immediate). */ static enum arm_type_qualifiers arm_sat_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] - = { qualifier_unsigned, qualifier_none, qualifier_unsigned_immediate }; + = { qualifier_none, qualifier_none, qualifier_unsigned_immediate }; #define SAT_BINOP_UNSIGNED_IMM_QUALIFIERS \ (arm_sat_binop_imm_qualifiers) diff --git a/gcc/testsuite/gcc.target/arm/pr109939.c b/gcc/testsuite/gcc.target/arm/pr109939.c new file mode 100644 index 000000000000..aafda7cd3cd3 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr109939.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target arm_sat_ok } */ +/* { dg-add-options arm_sat } */ +/* { dg-additional-options "-O -Wall -Wconversion" } */ + +#include + +int dbg_ssat_out; +int dbg_ssat_in; + +void test_arm_ssat(void) +{ + dbg_ssat_out = __ssat(dbg_ssat_in, 16); +} -- 2.47.2