From 955caf171c0370cf4a32eec9a18aca2b653e6b82 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Tue, 26 Sep 2017 13:56:36 +0200 Subject: [PATCH] qemu: fix hotplug of udp device with no connect host MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Use an empty string to let qemu fill out the default. This matches what's done in qemuBuildChrChardevStr. https://bugzilla.redhat.com/show_bug.cgi?id=1454671 Signed-off-by: Ján Tomko Reviewed-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 63b855920b..c63d250d36 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6522,7 +6522,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, case VIR_DOMAIN_CHR_TYPE_UDP: backend_type = "udp"; - addr = qemuMonitorJSONBuildInetSocketAddress(chr->data.udp.connectHost, + host = chr->data.udp.connectHost; + if (!host) + host = ""; + addr = qemuMonitorJSONBuildInetSocketAddress(host, chr->data.udp.connectService); if (!addr || virJSONValueObjectAppend(data, "remote", addr) < 0) -- 2.47.2