From 959ecee47488cab743b11a9654fabd63c255dd31 Mon Sep 17 00:00:00 2001 From: Adam Julis Date: Tue, 6 Aug 2024 09:01:24 +0200 Subject: [PATCH] network: NULL check for "modify" DNS-txt records The "modify" command allowed to replace an existing record, now checks for the NULL string in the new value and throw error if found. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/655 Signed-off-by: Adam Julis Reviewed-by: Michal Privoznik --- src/conf/network_conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 3af4e1d036..c23b0e4400 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -3385,6 +3385,13 @@ virNetworkDefUpdateDNSTxt(virNetworkDef *def, goto cleanup; } + if (!txt.value) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("missing value of modifying DNS TXT record in network %1$s"), + def->name); + goto cleanup; + } + VIR_FREE(dns->txts[foundIdx].value); dns->txts[foundIdx].value = g_steal_pointer(&txt.value); -- 2.47.2