From 95b830102087636d9117d91ba444cfffa63c4937 Mon Sep 17 00:00:00 2001
From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Sat, 27 Aug 2011 11:54:25 +0300
Subject: [PATCH] Bug 3301: ERR_DNS_FAIL never shown

Latest squid never shows DNS errors for user. When the user tries to retrieve
web page from non-existent domain, ERR_CANNOT_FORWARD error appears,
which misleads both user and administrator.
---
 src/forward.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/forward.cc b/src/forward.cc
index 15247665f6..941418c5b1 100644
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -303,13 +303,13 @@ FwdState::startConnectionOrFail()
 
         connectStart();
     } else {
-        debugs(17, 3, HERE << entry->url());
-        ErrorState *anErr = NULL;
-        if (err) {
+        debugs(17, 3, HERE << "Connection failed: " << entry->url());
+        if (!err) {
+            ErrorState *anErr = NULL;
             anErr = errorCon(ERR_CANNOT_FORWARD, HTTP_INTERNAL_SERVER_ERROR, request);
             anErr->xerrno = errno;
+            fail(anErr);
         } // else use actual error from last connection attempt
-        fail(anErr);
         self = NULL;       // refcounted
     }
 }
-- 
2.47.3