From 986f72f933c4f66481e8718a1b83960f9ea69c77 Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Mon, 25 May 2020 23:54:22 +0300 Subject: [PATCH] Rename dist/Chart* to dist/chart* (#7416) * Rename dist/Chart* to dist/chart* * Add a note to migration docs * Review update --- docs/docs/getting-started/integration.md | 6 +++--- docs/docs/getting-started/v3-migration.md | 1 + gulpfile.js | 2 +- package.json | 8 ++++---- rollup.config.js | 16 ++++++++-------- samples/advanced/line-gradient.html | 2 +- samples/advanced/progress-bar.html | 2 +- samples/advanced/radial-gradient.html | 2 +- samples/animations/delay.html | 2 +- samples/animations/drop.html | 2 +- samples/animations/loop.html | 2 +- samples/charts/area/line-boundaries.html | 2 +- samples/charts/area/line-datasets.html | 2 +- samples/charts/area/line-stacked.html | 2 +- samples/charts/area/radar.html | 2 +- samples/charts/bar/float.html | 2 +- samples/charts/bar/horizontal.html | 2 +- samples/charts/bar/multi-axis.html | 2 +- samples/charts/bar/stacked-group.html | 2 +- samples/charts/bar/stacked.html | 2 +- samples/charts/bar/vertical.html | 2 +- samples/charts/bubble.html | 2 +- samples/charts/combo-bar-line.html | 2 +- samples/charts/doughnut.html | 2 +- samples/charts/line/basic.html | 2 +- samples/charts/line/interpolation-modes.html | 2 +- samples/charts/line/line-styles.html | 2 +- samples/charts/line/multi-axis.html | 2 +- samples/charts/line/point-sizes.html | 2 +- samples/charts/line/point-styles.html | 2 +- samples/charts/line/skip-points.html | 2 +- samples/charts/line/stepped.html | 2 +- samples/charts/multi-series-pie.html | 2 +- samples/charts/pie.html | 2 +- samples/charts/polar-area.html | 2 +- samples/charts/radar-skip-points.html | 2 +- samples/charts/radar.html | 2 +- samples/charts/scatter/basic.html | 2 +- samples/charts/scatter/multi-axis.html | 2 +- samples/legend/callbacks.html | 2 +- samples/legend/point-style.html | 2 +- samples/legend/positioning.html | 2 +- samples/legend/title.html | 2 +- samples/scales/axes-labels.html | 2 +- samples/scales/axis-center-position.html | 2 +- samples/scales/filtering-labels.html | 2 +- samples/scales/financial.html | 2 +- samples/scales/gridlines-display.html | 2 +- samples/scales/gridlines-scriptable.html | 2 +- samples/scales/gridlines-style.html | 2 +- samples/scales/linear/min-max-suggested.html | 2 +- samples/scales/linear/min-max.html | 2 +- samples/scales/linear/step-size.html | 2 +- samples/scales/logarithmic/line.html | 2 +- samples/scales/logarithmic/scatter.html | 2 +- samples/scales/multiline-labels.html | 2 +- samples/scales/non-numeric-y.html | 2 +- samples/scales/time/combo.html | 2 +- samples/scales/time/line-max-span.html | 2 +- samples/scales/time/line-point-data.html | 2 +- samples/scales/time/line.html | 2 +- samples/scales/toggle-scale-type.html | 2 +- samples/scriptable/bar.html | 2 +- samples/scriptable/bubble.html | 2 +- samples/scriptable/line.html | 2 +- samples/scriptable/pie.html | 2 +- samples/scriptable/polar.html | 2 +- samples/scriptable/radar.html | 2 +- samples/title/alignment.html | 2 +- samples/tooltips/border.html | 2 +- samples/tooltips/callbacks.html | 2 +- samples/tooltips/custom-line.html | 2 +- samples/tooltips/custom-pie.html | 2 +- samples/tooltips/custom-points.html | 2 +- samples/tooltips/interactions.html | 2 +- samples/tooltips/positioning.html | 2 +- scripts/deploy.sh | 2 +- 77 files changed, 89 insertions(+), 88 deletions(-) diff --git a/docs/docs/getting-started/integration.md b/docs/docs/getting-started/integration.md index e23e2be63..687b00474 100644 --- a/docs/docs/getting-started/integration.md +++ b/docs/docs/getting-started/integration.md @@ -7,7 +7,7 @@ Chart.js can be integrated with plain JavaScript or with different module loader ## Script Tag ```html - + @@ -29,10 +29,10 @@ var myChart = new Chart(ctx, {...}); ## Require JS -**Important:** RequireJS [can **not** load CommonJS module as is](https://requirejs.org/docs/commonjs.html#intro), so be sure to require one of the UMD builds instead (i.e. `dist/Chart.js`, `dist/Chart.min.js`, etc.). +**Important:** RequireJS [can **not** load CommonJS module as is](https://requirejs.org/docs/commonjs.html#intro), so be sure to require one of the UMD builds instead (i.e. `dist/chart.js`, `dist/chart.min.js`, etc.). ```javascript -require(['path/to/chartjs/dist/Chart.min.js'], function(Chart){ +require(['path/to/chartjs/dist/chart.min.js'], function(Chart){ var myChart = new Chart(ctx, {...}); }); ``` diff --git a/docs/docs/getting-started/v3-migration.md b/docs/docs/getting-started/v3-migration.md index a1de622e1..81b9ae1f1 100644 --- a/docs/docs/getting-started/v3-migration.md +++ b/docs/docs/getting-started/v3-migration.md @@ -17,6 +17,7 @@ Chart.js 3.0 introduces a number of breaking changes. Chart.js 2.0 was released ### Setup and installation +* Distributed files are now in lower case. For example: `dist/chart.js`. * Chart.js is no longer providing the `Chart.bundle.js` and `Chart.bundle.min.js`. Please see the [installation](installation.md) and [integration](integration.md) docs for details on the recommended way to setup Chart.js if you were using these builds. * `moment` is no longer specified as an npm dependency. If you are using the time scale, you must include one of [the available adapters](https://github.com/chartjs/awesome#adapters) and corresponding date library. You no longer need to exclude moment from your build. diff --git a/gulpfile.js b/gulpfile.js index 5c4270a0a..e1a673c8b 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -133,7 +133,7 @@ function unittestTask(done) { } function librarySizeTask() { - return gulp.src('dist/Chart.bundle.min.js') + return gulp.src('dist/chart.min.js') .pipe(size({ gzip: true })); diff --git a/package.json b/package.json index 5cbfb51a3..7ee84f647 100644 --- a/package.json +++ b/package.json @@ -4,10 +4,10 @@ "description": "Simple HTML5 charts using the canvas element.", "version": "3.0.0-alpha", "license": "MIT", - "jsdelivr": "dist/Chart.min.js", - "unpkg": "dist/Chart.min.js", - "main": "dist/Chart.js", - "module": "dist/Chart.esm.js", + "jsdelivr": "dist/chart.min.js", + "unpkg": "dist/chart.min.js", + "main": "dist/chart.js", + "module": "dist/chart.esm.js", "keywords": [ "canvas", "charts", diff --git a/rollup.config.js b/rollup.config.js index 6033bbc51..beba09218 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -20,8 +20,8 @@ const banner = `/*! module.exports = [ // UMD builds - // dist/Chart.min.js - // dist/Chart.js + // dist/chart.min.js + // dist/chart.js { input, plugins: [ @@ -37,7 +37,7 @@ module.exports = [ ], output: { name: 'Chart', - file: 'dist/Chart.js', + file: 'dist/chart.js', banner, format: 'umd', indent: false, @@ -60,15 +60,15 @@ module.exports = [ ], output: { name: 'Chart', - file: 'dist/Chart.min.js', + file: 'dist/chart.min.js', format: 'umd', indent: false, }, }, // ES6 builds - // dist/Chart.esm.min.js - // dist/Chart.esm.js + // dist/chart.esm.min.js + // dist/chart.esm.js { input, plugins: [ @@ -81,7 +81,7 @@ module.exports = [ ], output: { name: 'Chart', - file: 'dist/Chart.esm.js', + file: 'dist/chart.esm.js', banner, format: 'esm', indent: false, @@ -101,7 +101,7 @@ module.exports = [ ], output: { name: 'Chart', - file: 'dist/Chart.esm.min.js', + file: 'dist/chart.esm.min.js', format: 'esm', indent: false, }, diff --git a/samples/advanced/line-gradient.html b/samples/advanced/line-gradient.html index bbbd08259..462c35475 100644 --- a/samples/advanced/line-gradient.html +++ b/samples/advanced/line-gradient.html @@ -2,7 +2,7 @@ Linear Gradient - +