From 98b8275d92bcefaed8b14a990b33555d61c1796e Mon Sep 17 00:00:00 2001 From: Alexander Wetzel Date: Wed, 4 Mar 2020 18:16:54 +0100 Subject: [PATCH] nl80211: Remove not needed netlink key attribute Calling NL80211_CMD_NEW_KEY with NL80211_KEY_DEFAULT_TYPES attributes is pointless. The information is not expected and therefore the kernel never forwards it to the drivers. That attribute is used with NL80211_CMD_SET_KEY. Signed-off-by: Alexander Wetzel --- src/drivers/driver_nl80211.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 2e61eb7e1..94c56d007 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -3142,15 +3142,7 @@ static int wpa_driver_nl80211_set_key(struct i802_bss *bss, goto fail; } } else if (addr && is_broadcast_ether_addr(addr)) { - struct nlattr *types; - wpa_printf(MSG_DEBUG, " broadcast key"); - - types = nla_nest_start(key_msg, NL80211_KEY_DEFAULT_TYPES); - if (!types || - nla_put_flag(key_msg, NL80211_KEY_DEFAULT_TYPE_MULTICAST)) - goto fail; - nla_nest_end(key_msg, types); } if (nla_put_u8(key_msg, NL80211_KEY_IDX, key_idx) || nla_put_nested(msg, NL80211_ATTR_KEY, key_msg)) -- 2.47.2