From 98c1dcc6bcade313a254fe11e8efa3c5b5ad959e Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Wed, 28 Oct 2015 11:22:55 -0400 Subject: [PATCH] - add a JSON warning for coerce_compared_value --- lib/sqlalchemy/sql/type_api.py | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/lib/sqlalchemy/sql/type_api.py b/lib/sqlalchemy/sql/type_api.py index 3b53912347..bc67270eb2 100644 --- a/lib/sqlalchemy/sql/type_api.py +++ b/lib/sqlalchemy/sql/type_api.py @@ -729,6 +729,26 @@ class TypeDecorator(SchemaEventTarget, TypeEngine): else: return self + .. warning:: + + Note that the **behavior of coerce_compared_value is not inherited + by default from that of the base type**. + If the :class:`.TypeDecorator` is augmenting a + type that requires special logic for certain types of operators, + this method **must** be overridden. A key example is when decorating + the :class:`.postgresql.JSON` and :class:`.postgresql.JSONB` types; + the default rules of :meth:`.TypeEngine.coerce_compared_value` should + be used in order to deal with operators like index operations:: + + class MyJsonType(TypeDecorator): + impl = postgresql.JSON + + def coerce_compared_value(self, op, value): + return self.impl.coerce_compared_value(op, value) + + Without the above step, index operations such as ``mycol['foo']`` + will cause the index value ``'foo'`` to be JSON encoded. + """ __visit_name__ = "type_decorator" -- 2.47.2