From 996a8ca9bbf0cb9c9caea7926bc160d0c1fd7648 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sun, 14 Feb 2021 12:13:56 -0500 Subject: [PATCH] fix typos Change-Id: Ifb9e75e5af9412224b1e75491c497ba67e2018d4 --- doc/build/changelog/migration_14.rst | 16 +++++++++------- doc/build/changelog/unreleased_14/5941.rst | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/doc/build/changelog/migration_14.rst b/doc/build/changelog/migration_14.rst index 7bd9f9d315..1911c55aa6 100644 --- a/doc/build/changelog/migration_14.rst +++ b/doc/build/changelog/migration_14.rst @@ -2583,14 +2583,16 @@ psycopg2 dialect no longer has limitations regarding bound parameter names -------------------------------------------------------------------------- SQLAlchemy 1.3 was not able to accommodate bound parameter names that included -percent signs or parenthesis under the psycopg2 dialect, which meant that -column names which included these characters were also problematic as +percent signs or parenthesis under the psycopg2 dialect. This in turn meant +that column names which included these characters were also problematic as INSERT and other DML statements would generate parameter names that matched -that of the column, unless the :paramref:`_schema.Column.key` parameter -were used to provide an alternate name that would be used to generate -the parameter, or otherwise the parameter style of the dialect had to be -changed. As of SQLAlchemy 1.4.0beta3 all naming limitations have been removed -and parameters are fully escaped in all scenarios. +that of the column, which would then cause failures. The workaround was to make +use of the :paramref:`_schema.Column.key` parameter so that an alternate name +that would be used to generate the parameter, or otherwise the parameter style +of the dialect had to be changed at the :func:`_sa.create_engine` level. As of +SQLAlchemy 1.4.0beta3 all naming limitations have been removed and parameters +are fully escaped in all scenarios, so these workarounds are no longer +necessary. :ticket:`5941` diff --git a/doc/build/changelog/unreleased_14/5941.rst b/doc/build/changelog/unreleased_14/5941.rst index 5f5f116f8e..103db5412f 100644 --- a/doc/build/changelog/unreleased_14/5941.rst +++ b/doc/build/changelog/unreleased_14/5941.rst @@ -10,7 +10,7 @@ parenthesis in psycopg2's "pyformat" style. As part of this change, the format used by the asyncpg DBAPI adapter (which - is local to SQLAlchemy's asyncpg diaelct) has been changed from using + is local to SQLAlchemy's asyncpg dialect) has been changed from using "qmark" paramstyle to "format", as there is a standard and internally supported SQL string escaping style for names that use percent signs with "format" style (i.e. to double percent signs), as opposed to names that use -- 2.47.2