From 999595a651a87f4285c53710b5f600d6a141f526 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Sun, 9 Feb 2025 07:31:27 -0500 Subject: [PATCH] nfsd: handle NFS4ERR_BADSLOT on CB_SEQUENCE better Currently it just restarts the call, without getting a new slot. Signed-off-by: Jeff Layton Signed-off-by: Chuck Lever --- fs/nfsd/nfs4callback.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index a9e88df17f7a3..39c2f7c8c3190 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1389,6 +1389,13 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback rpc_delay(task, 2 * HZ); return false; case -NFS4ERR_BADSLOT: + /* + * BADSLOT means that the client and server are out of sync + * as to the backchannel parameters. Mark the backchannel faulty + * and restart the RPC, but leak the slot so no one uses it. + */ + nfsd4_mark_cb_fault(cb->cb_clp); + cb->cb_held_slot = -1; goto retry_nowait; case -NFS4ERR_SEQ_MISORDERED: if (session->se_cb_seq_nr[cb->cb_held_slot] != 1) { -- 2.47.2