From 99ce4a0f462aa61cfd9805cb42531fa73208faad Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Fri, 1 Mar 2013 03:04:57 -0700 Subject: [PATCH] Docs: document ConnOpener::swanSong() better --- src/comm/ConnOpener.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/comm/ConnOpener.cc b/src/comm/ConnOpener.cc index a253faf6a7..634b9f1d74 100644 --- a/src/comm/ConnOpener.cc +++ b/src/comm/ConnOpener.cc @@ -67,9 +67,11 @@ Comm::ConnOpener::swanSong() sendAnswer(COMM_ERR_CONNECT, 0, "Comm::ConnOpener::swanSong"); } + // did we abort with a temporary FD assigned? if (temporaryFd_ >= 0) closeFd(); + // did we abort while waiting between retries? if (calls_.sleep_) cancelSleep(); @@ -120,6 +122,7 @@ Comm::ConnOpener::sendAnswer(comm_err_t errFlag, int xerrno, const char *why) if (callback_->canceled()) { debugs(5, 4, conn_ << " not calling canceled " << *callback_ << " [" << callback_->id << ']' ); + // TODO save the pconn to the pconnPool ? } else { typedef CommConnectCbParams Params; Params ¶ms = GetCommParams(callback_); -- 2.47.2