From 9a612a850cc0de1a3956ecb2af59010e30adce04 Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Fri, 14 Mar 2025 12:54:56 +0100 Subject: [PATCH] [3.12] gh-131234: Improve `test_popen` with more asserts (GH-131235) (#131241) gh-131234: Improve `test_popen` with more asserts (GH-131235) (cherry picked from commit fc07f863ee2a942dd96e1ca9edf049603fbb574e) Co-authored-by: sobolevn --- Lib/test/test_popen.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_popen.py b/Lib/test/test_popen.py index e6bfc480cbd1..34cda35b17bd 100644 --- a/Lib/test/test_popen.py +++ b/Lib/test/test_popen.py @@ -57,14 +57,21 @@ class PopenTest(unittest.TestCase): def test_contextmanager(self): with os.popen("echo hello") as f: self.assertEqual(f.read(), "hello\n") + self.assertFalse(f.closed) + self.assertTrue(f.closed) def test_iterating(self): with os.popen("echo hello") as f: self.assertEqual(list(f), ["hello\n"]) + self.assertFalse(f.closed) + self.assertTrue(f.closed) def test_keywords(self): - with os.popen(cmd="exit 0", mode="w", buffering=-1): - pass + with os.popen(cmd="echo hello", mode="r", buffering=-1) as f: + self.assertEqual(f.read(), "hello\n") + self.assertFalse(f.closed) + self.assertTrue(f.closed) + if __name__ == "__main__": unittest.main() -- 2.47.3