From 9b1dc2a4ca61aaa96c3e731a7a59da2a21aa522d Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Mon, 21 Dec 2020 15:31:25 +0100 Subject: [PATCH] s3:smbd: make sure openat_pathref_fsp() calls fd_close(fsp->base_fsp); Signed-off-by: Stefan Metzmacher Reviewed-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source3/smbd/files.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/smbd/files.c b/source3/smbd/files.c index 122afa4f3d6..bb61fd49c9c 100644 --- a/source3/smbd/files.c +++ b/source3/smbd/files.c @@ -479,10 +479,10 @@ NTSTATUS openat_pathref_fsp(const struct files_struct *dirfsp, nt_errstr(status)); if (fsp->base_fsp != NULL) { + fd_close(fsp->base_fsp); file_free(NULL, fsp->base_fsp); fsp->base_fsp = NULL; } - fd_close(fsp); file_free(NULL, fsp); fsp = NULL; @@ -547,6 +547,7 @@ fail: return status; } if (fsp->base_fsp != NULL) { + fd_close(fsp->base_fsp); file_free(NULL, fsp->base_fsp); fsp->base_fsp = NULL; } -- 2.47.2