From 9bc407c787771baad6c69cee3e392f15a5b9163d Mon Sep 17 00:00:00 2001 From: Kyrylo Tkachov Date: Wed, 19 Apr 2023 10:32:07 +0100 Subject: [PATCH] aarch64: Delete __builtin_aarch64_neg* builtins and their use I don't think we need to keep the __builtin_aarch64_neg* builtins around. They are only used once in the vnegh_f16 intrinsic in arm_fp16.h and I AFAICT it was added this way only for the sake of orthogonality in https://gcc.gnu.org/g:d7f33f07d88984cbe769047e3d07fc21067fbba9 We already use normal "-" negation in the other vneg* intrinsics, so do so here as well. Bootstrapped and tested on aarch64-none-linux-gnu. gcc/ChangeLog: * config/aarch64/aarch64-simd-builtins.def (neg): Delete builtins definition. * config/aarch64/arm_fp16.h (vnegh_f16): Reimplement using normal negation. --- gcc/config/aarch64/aarch64-simd-builtins.def | 3 --- gcc/config/aarch64/arm_fp16.h | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def b/gcc/config/aarch64/aarch64-simd-builtins.def index ea5fd33a28ab..1beaa08c1e7c 100644 --- a/gcc/config/aarch64/aarch64-simd-builtins.def +++ b/gcc/config/aarch64/aarch64-simd-builtins.def @@ -848,9 +848,6 @@ BUILTIN_VHSDF_HSDF (BINOP_USS, cmle, 0, FP) BUILTIN_VHSDF_HSDF (BINOP_USS, cmlt, 0, FP) - /* Implemented by neg2. */ - BUILTIN_VHSDF_HSDF (UNOP, neg, 2, ALL) - /* Implemented by aarch64_fac. */ BUILTIN_VHSDF_HSDF (BINOP_USS, faclt, 0, FP) BUILTIN_VHSDF_HSDF (BINOP_USS, facle, 0, FP) diff --git a/gcc/config/aarch64/arm_fp16.h b/gcc/config/aarch64/arm_fp16.h index a8fa4dbbdfe1..350f8cc33d99 100644 --- a/gcc/config/aarch64/arm_fp16.h +++ b/gcc/config/aarch64/arm_fp16.h @@ -334,7 +334,7 @@ __extension__ extern __inline float16_t __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) vnegh_f16 (float16_t __a) { - return __builtin_aarch64_neghf (__a); + return -__a; } __extension__ extern __inline float16_t -- 2.47.2