From 9bdd30ba17f6a2490c670e121395a70abcca7233 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 12 Nov 2003 09:23:03 +0000 Subject: [PATCH] (extract_dirs_from_files): Avoid useless copy operations. This avoids a warning valgrind about memcpy with overlapping source and destination. --- src/ls.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/ls.c b/src/ls.c index c8d471f89a..8243dffcba 100644 --- a/src/ls.c +++ b/src/ls.c @@ -2582,8 +2582,14 @@ extract_dirs_from_files (const char *dirname, int ignore_dot_and_dot_dot) entries. */ for (i = 0, j = 0; i < files_index; i++) - if (files[i].filetype != arg_directory) - files[j++] = files[i]; + { + if (files[i].filetype != arg_directory) + { + if (j < i) + files[j] = files[i]; + ++j; + } + } files_index = j; } -- 2.47.2