From 9bf5ca8620c0aba912d3a8b9b31b9ca8af85e476 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 25 Jul 2018 14:25:01 +0200 Subject: [PATCH] lxc: Enable under valgrind again So we originally disabled LXC driver when libvirtd is running under valgrind back in 05436ab7ff087 (which dates to beginning of 2009) as it was causing valgrind to crash. It's not the case anymore. Valgrind works with LXC happily. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/lxc/lxc_driver.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 6969dddcab..8867645cdc 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1550,19 +1550,8 @@ static int lxcStateInitialize(bool privileged, void *opaque ATTRIBUTE_UNUSED) { virCapsPtr caps = NULL; - const char *ld; virLXCDriverConfigPtr cfg = NULL; - /* Valgrind gets very annoyed when we clone containers, so - * disable LXC when under valgrind - * XXX remove this when valgrind is fixed - */ - ld = virGetEnvBlockSUID("LD_PRELOAD"); - if (ld && strstr(ld, "vgpreload")) { - VIR_INFO("Running under valgrind, disabling driver"); - return 0; - } - /* Check that the user is root, silently disable if not */ if (!privileged) { VIR_INFO("Not running privileged, disabling driver"); -- 2.47.2