From 9bffd891bcc98807f259fdb6f95a0264c5be66be Mon Sep 17 00:00:00 2001 From: Bob Halley Date: Sun, 4 Feb 2024 13:41:09 -0800 Subject: [PATCH] The EDNS Option base class should have a NotImplemented to_text(). --- dns/edns.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dns/edns.py b/dns/edns.py index f05baac4..c80e0482 100644 --- a/dns/edns.py +++ b/dns/edns.py @@ -58,7 +58,6 @@ class OptionType(dns.enum.IntEnum): class Option: - """Base class for all EDNS option types.""" def __init__(self, otype: Union[OptionType, str]): @@ -76,6 +75,9 @@ class Option: """ raise NotImplementedError # pragma: no cover + def to_text(self) -> str: + raise NotImplementedError # pragma: no cover + @classmethod def from_wire_parser(cls, otype: OptionType, parser: "dns.wire.Parser") -> "Option": """Build an EDNS option object from wire format. @@ -141,7 +143,6 @@ class Option: class GenericOption(Option): # lgtm[py/missing-equals] - """Generic Option Class This class is used for EDNS option types for which we have no better -- 2.47.3