From 9d2c11e54f3421fd95a0966ac114366808cfb65f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 15 Mar 2023 21:47:56 +0000 Subject: [PATCH] ds: reap_pids: remove redundant signal blocking Blocking signals when reaping was done when the lei pager was spawned by the daemon in b90e8d6e02. Shortly afterwards in 7b79c918a5, the client script took over spawning of the pager and made b90e8d6e02 redundant. cf. b90e8d6e02 (ds: block signals when reaping, 2021-01-10) 7b79c918a5 (lei: run pager in client script, 2021-01-10) --- lib/PublicInbox/DS.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index a08e01f54..b6eaf2d75 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -214,7 +214,6 @@ sub await_cb ($;@) { # that to remain the case. sub reap_pids { $reap_armed = undef; - my $oldset = block_signals(); while (1) { my $pid = waitpid(-1, WNOHANG) // last; last if $pid <= 0; @@ -224,7 +223,6 @@ sub reap_pids { warn "W: reaped unknown PID=$pid: \$?=$?\n"; } } - sig_setmask($oldset); } # reentrant SIGCHLD handler (since reap_pids is not reentrant) -- 2.47.2