From 9e143ee9b9f7be53c193cee3153f64c4dedc07e9 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 28 May 2018 14:12:52 +1200 Subject: [PATCH] ldb: Explain why an entry can vanish from the index Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher Reviewed-by: Garming Sam --- lib/ldb/ldb_tdb/ldb_index.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/ldb/ldb_tdb/ldb_index.c b/lib/ldb/ldb_tdb/ldb_index.c index 1a5867b7a0d..041dbdc4ed6 100644 --- a/lib/ldb/ldb_tdb/ldb_index.c +++ b/lib/ldb/ldb_tdb/ldb_index.c @@ -1821,7 +1821,12 @@ static int ltdb_index_filter(struct ltdb_private *ltdb, LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC| LDB_UNPACK_DATA_FLAG_NO_VALUES_ALLOC); if (ret == LDB_ERR_NO_SUCH_OBJECT) { - /* the record has disappeared? yes, this can happen */ + /* + * the record has disappeared? yes, this can + * happen if the entry is deleted by something + * operating in the callback (not another + * process, as we have a read lock) + */ talloc_free(msg); continue; } -- 2.47.2