From 9ed211a15eacb5fa32825129f642a40c54b83ea0 Mon Sep 17 00:00:00 2001 From: Gord Thompson Date: Sat, 23 Oct 2021 16:41:19 -0600 Subject: [PATCH] Adjust test requirements for mssql SQLAlchemy added FK onupdate/ondelete reflection in 1.4.26 Change-Id: Ie4e95294fe3857ea1f28a67a7a78ca9213e8e8f8 --- alembic/util/sqla_compat.py | 1 + tests/requirements.py | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/alembic/util/sqla_compat.py b/alembic/util/sqla_compat.py index b2b6f065..21dee892 100644 --- a/alembic/util/sqla_compat.py +++ b/alembic/util/sqla_compat.py @@ -57,6 +57,7 @@ _vers = tuple( ) sqla_13 = _vers >= (1, 3) sqla_14 = _vers >= (1, 4) +sqla_14_26 = _vers >= (1, 4, 26) try: from sqlalchemy import Computed # noqa diff --git a/tests/requirements.py b/tests/requirements.py index 61c35623..7770da90 100644 --- a/tests/requirements.py +++ b/tests/requirements.py @@ -97,11 +97,23 @@ class DefaultRequirements(SuiteRequirements): @property def fk_ondelete_is_reflected(self): - return exclusions.fails_on(["mssql"]) + def go(config): + if exclusions.against(config, "mssql"): + return not sqla_compat.sqla_14_26 + else: + return False + + return exclusions.fails_if(go) @property def fk_onupdate_is_reflected(self): - return self.fk_onupdate + exclusions.fails_on(["mssql"]) + def go(config): + if exclusions.against(config, "mssql"): + return not sqla_compat.sqla_14_26 + else: + return False + + return self.fk_onupdate + exclusions.fails_if(go) @property def fk_onupdate(self): -- 2.47.2