From 9f07af1d274223a4314b5e2e6d395a78166c24c5 Mon Sep 17 00:00:00 2001 From: Heiner Kallweit Date: Mon, 10 Nov 2025 22:20:26 +0100 Subject: [PATCH] net: phy: fixed_phy: initialize the link status as up All callers initialize the link status as up. This change is in line with how of_phy_register_fixed_link() behaves. Signed-off-by: Heiner Kallweit Link: https://patch.msgid.link/45f644e8-2292-4787-a27a-f69084c93218@gmail.com Signed-off-by: Paolo Abeni --- drivers/net/phy/fixed_phy.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 9bd6937411e43..715f0356f895f 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -174,13 +174,11 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status, } /* propagate the fixed link values to struct phy_device */ - phy->link = status->link; - if (status->link) { - phy->speed = status->speed; - phy->duplex = status->duplex; - phy->pause = status->pause; - phy->asym_pause = status->asym_pause; - } + phy->link = 1; + phy->speed = status->speed; + phy->duplex = status->duplex; + phy->pause = status->pause; + phy->asym_pause = status->asym_pause; of_node_get(np); phy->mdio.dev.of_node = np; @@ -224,7 +222,6 @@ EXPORT_SYMBOL_GPL(fixed_phy_register); struct phy_device *fixed_phy_register_100fd(void) { static const struct fixed_phy_status status = { - .link = true, .speed = SPEED_100, .duplex = DUPLEX_FULL, }; -- 2.47.3