From 9fea3fcd14c0c9d6c9a881b96891c6eccf7de057 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Wed, 8 Sep 2021 16:02:34 +0200 Subject: [PATCH] dnsdist: Document the revert to 10 TCP workers by default --- pdns/dnsdistdist/docs/reference/tuning.rst | 8 ++++++-- pdns/dnsdistdist/docs/upgrade_guide.rst | 5 +++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/pdns/dnsdistdist/docs/reference/tuning.rst b/pdns/dnsdistdist/docs/reference/tuning.rst index c8911c26a2..f899951077 100644 --- a/pdns/dnsdistdist/docs/reference/tuning.rst +++ b/pdns/dnsdistdist/docs/reference/tuning.rst @@ -13,12 +13,16 @@ Tuning related functions .. versionchanged:: 1.6.0 Before 1.6.0 the default value was 10. + .. versionchanged:: 1.6.1 + The default value has been set back to 10. Set the maximum of TCP client threads, handling TCP connections. Before 1.4.0 a TCP thread could only handle a single incoming TCP connection at a time, while after 1.4.0 it can handle a larger number of them simultaneously. - Since 1.6.0, the default value is at least 10 TCP workers, but might be more if there is more than 10 TCP listeners (added via :func:`addDNSCryptBind`, :func:`addLocal`, or :func:`addTLSLocal`). In that last case there will be as many TCP workers as TCP listeners. + Note that before 1.6.0 the TCP worker threads were created at runtime, adding a new thread when the existing ones seemed to struggle with the load, until the maximum number of threads had been reached. Starting with 1.6.0 the configured number of worker threads are immediately created at startup. - :param int num: + In 1.6.0 the default value was at least 10 TCP workers, but could be more if there is more than 10 TCP listeners (added via :func:`addDNSCryptBind`, :func:`addLocal`, or :func:`addTLSLocal`). In that last case there would have been as many TCP workers as TCP listeners. This led to issues in setups with a large number of TCP listeners and was therefore reverted back to 10 in 1.6.1. + + :param int num: The number of TCP worker threads. .. function:: setMaxTCPConnectionDuration(num) diff --git a/pdns/dnsdistdist/docs/upgrade_guide.rst b/pdns/dnsdistdist/docs/upgrade_guide.rst index 09aafe690f..487a7e9876 100644 --- a/pdns/dnsdistdist/docs/upgrade_guide.rst +++ b/pdns/dnsdistdist/docs/upgrade_guide.rst @@ -8,6 +8,11 @@ Truncated responses received over UDP for DoH clients will now be retried over T :func:`setTCPUseSinglePipe` has been removed. +1.6.0 to 1.6.1 +-------------- + +Unless set via :func:`setMaxTCPClientThreads` the number of TCP workers now defaults to 10, instead of the number of TCP binds. + 1.5.x to 1.6.0 -------------- -- 2.47.2