From a1709a68a5ca687bfbda8ee57e1753660b5d2aa6 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 2 Feb 2021 17:05:23 +0100 Subject: [PATCH] cmdSecretGetValue: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrangé --- tools/virsh-secret.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index de32f25d64..fcfbe5fe9e 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -302,7 +302,6 @@ static bool cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshSecret) secret = NULL; - VIR_AUTODISPOSE_STR base64 = NULL; g_autofree unsigned char *value = NULL; size_t value_size; bool plain = vshCommandOptBool(cmd, "plain"); @@ -320,9 +319,10 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) return false; } } else { - base64 = g_base64_encode(value, value_size); + g_autofree char *base64 = g_base64_encode(value, value_size); vshPrint(ctl, "%s", base64); + virSecureEraseString(base64); } virSecureErase(value, value_size); -- 2.47.2