From a2356a89f7cb42c91fdf607ffe0af3ecc7df5a4b Mon Sep 17 00:00:00 2001
From: Victor Julien <victor@inliniac.net>
Date: Tue, 17 Sep 2019 10:41:59 +0200
Subject: [PATCH] detect/dns.opcode: improve error reporting

---
 src/detect-dns-opcode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/detect-dns-opcode.c b/src/detect-dns-opcode.c
index 1d90b0668b..68edcdca41 100644
--- a/src/detect-dns-opcode.c
+++ b/src/detect-dns-opcode.c
@@ -38,7 +38,8 @@ static int DetectDnsOpcodeSetup(DetectEngineCtx *de_ctx, Signature *s,
 
     void *detect = rs_detect_dns_opcode_parse(str);
     if (detect == NULL) {
-        SCLogNotice("Failed to parse dns.opcode: %s", str);
+        SCLogError(SC_ERR_INVALID_RULE_ARGUMENT,
+                "failed to parse dns.opcode: %s", str);
         return -1;
     }
 
-- 
2.47.2