From a320f53cb76b64c5b94476f6f0e61815ee095332 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 29 Jul 2016 14:00:10 +0200 Subject: [PATCH] ldb: Fix two signed/unsigned hickups Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- lib/ldb/common/ldb_dn.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c index 3fa5ab57056..b23ee1734cd 100644 --- a/lib/ldb/common/ldb_dn.c +++ b/lib/ldb/common/ldb_dn.c @@ -1699,7 +1699,7 @@ bool ldb_dn_remove_child_components(struct ldb_dn *dn, unsigned int num) */ bool ldb_dn_replace_components(struct ldb_dn *dn, struct ldb_dn *new_dn) { - int i; + unsigned int i; if ( ! ldb_dn_validate(dn) || ! ldb_dn_validate(new_dn)) { return false; @@ -1904,11 +1904,11 @@ int ldb_dn_set_component(struct ldb_dn *dn, int num, return LDB_ERR_OTHER; } - if (num >= dn->comp_num) { + if (num < 0) { return LDB_ERR_OTHER; } - if (num < 0) { + if ((unsigned)num >= dn->comp_num) { return LDB_ERR_OTHER; } -- 2.47.2