From a384f2ed886d4417d50fdad78aaf1ccf870d62e6 Mon Sep 17 00:00:00 2001 From: Vladimir Kondratiev Date: Sun, 18 Jan 2026 10:28:43 +0200 Subject: [PATCH] irqchip/aslint-sswi: Fix error check of of_io_request_and_map() result of_io_request_and_map() returns IOMEM_ERR_PTR() on failure which is non-NULL. Fixes: 8a7f030df897 ("irqchip/aslint-sswi: Request IO memory resource") Reported-by: Chris Mason Signed-off-by: Vladimir Kondratiev Signed-off-by: Thomas Gleixner Link: https://patch.msgid.link/20260118082843.2786630-1-vladimir.kondratiev@mobileye.com Closes: https://lore.kernel.org/all/20260116124257.78357-1-clm@meta.com --- drivers/irqchip/irq-aclint-sswi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-aclint-sswi.c b/drivers/irqchip/irq-aclint-sswi.c index 325501f34a9bc..ca06efd86fa1a 100644 --- a/drivers/irqchip/irq-aclint-sswi.c +++ b/drivers/irqchip/irq-aclint-sswi.c @@ -110,8 +110,10 @@ static int __init aclint_sswi_probe(struct fwnode_handle *fwnode) return -EINVAL; reg = of_io_request_and_map(to_of_node(fwnode), 0, NULL); - if (!reg) - return -ENOMEM; + if (IS_ERR(reg)) { + pr_err("%pfwP: Failed to map MMIO region\n", fwnode); + return PTR_ERR(reg); + } /* Parse SSWI setting */ rc = aclint_sswi_parse_irq(fwnode, reg); -- 2.47.3