From a3b3d2dc389568a77d0e25da17203e3616218e93 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Tue, 7 Jan 2025 14:47:01 +0000 Subject: [PATCH] net: hsr: remove synchronize_rcu() from hsr_add_port() A synchronize_rcu() was added by mistake in commit c5a759117210 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.") RCU does not mandate to observe a grace period after list_add_tail_rcu(). Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250107144701.503884-1-edumazet@google.com Signed-off-by: Paolo Abeni --- net/hsr/hsr_slave.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c index 006d6ef97e53f..2a802a5de2acc 100644 --- a/net/hsr/hsr_slave.c +++ b/net/hsr/hsr_slave.c @@ -204,7 +204,6 @@ int hsr_add_port(struct hsr_priv *hsr, struct net_device *dev, } list_add_tail_rcu(&port->port_list, &hsr->ports); - synchronize_rcu(); master = hsr_port_get_hsr(hsr, HSR_PT_MASTER); netdev_update_features(master->dev); -- 2.39.5