From a41706b6c02f2da22a8bffb419efea32597c9253 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Fri, 14 Jan 2022 10:58:25 +0100 Subject: [PATCH] Process review comments on comments --- pdns/sha.hh | 2 +- pdns/zonemd.cc | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pdns/sha.hh b/pdns/sha.hh index b9c8ff5fb9..bf8cc4eaf9 100644 --- a/pdns/sha.hh +++ b/pdns/sha.hh @@ -84,7 +84,7 @@ public: ~SHADigest() { - // No free of md needed afaik + // No free of md needed and mdctx is cleaned up by unique_ptr } void process(const std::string& msg) diff --git a/pdns/zonemd.cc b/pdns/zonemd.cc index fe7fae2bff..51ac3d00ce 100644 --- a/pdns/zonemd.cc +++ b/pdns/zonemd.cc @@ -51,7 +51,6 @@ void pdns::zonemdVerify(const DNSName& zone, ZoneParserTNG& zpt, bool& validatio continue; } if (dnsResourceRecord.qtype == QType::SOA && soaRecordContent) { - // XXX skip extra SOA? continue; } std::shared_ptr drc; @@ -73,7 +72,7 @@ void pdns::zonemdVerify(const DNSName& zone, ZoneParserTNG& zpt, bool& validatio auto zonemd = std::dynamic_pointer_cast(drc); auto inserted = zonemdRecords.insert({pair(zonemd->d_scheme, zonemd->d_hashalgo), {zonemd, false}}); if (!inserted.second) { - // Mark as duplicate; + // Mark as duplicate inserted.first->second.duplicate = true; } } -- 2.47.2