From a4756138cf402b1994f808f02ae5ba889455115d Mon Sep 17 00:00:00 2001 From: Ralph Eastwood Date: Wed, 16 Aug 2023 13:30:01 +0200 Subject: [PATCH] napatech: print NUMA recommendation early When thread affinity is set, the NUMA configuration specified in the napatech.ini configuration could be incorrect and then fail. This fails before the recommended configuration is printed, which is pretty unhelpful. --- src/source-napatech.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/source-napatech.c b/src/source-napatech.c index d1d57f856a..44201a2bb3 100644 --- a/src/source-napatech.c +++ b/src/source-napatech.c @@ -845,6 +845,9 @@ TmEcode NapatechPacketLoop(ThreadVars *tv, void *data, void *slot) SC_ATOMIC_ADD(stream_count, 1); if (SC_ATOMIC_GET(stream_count) == NapatechGetNumConfiguredStreams()) { + /* Print the recommended NUMA configuration early because it + * can fail with "No available hostbuffers" in NapatechSetupTraffic */ + RecommendNUMAConfig(); #ifdef NAPATECH_ENABLE_BYPASS if (ConfGetBool("napatech.inline", &is_inline) == 0) { @@ -869,7 +872,6 @@ TmEcode NapatechPacketLoop(ThreadVars *tv, void *data, void *slot) } else if (status == 0x20000008) { FatalError("Check napatech.ports in the suricata config file."); } - RecommendNUMAConfig(); SCLogNotice("Napatech packet input engine started."); } } // is_autoconfig -- 2.47.2