From a48ffe47cf1db98694d2013bf97f62f55e4c3d27 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Mon, 28 Feb 2022 11:15:01 +0900 Subject: [PATCH] network: refuse to configure link properties when in initialized state The condition should be satisfied only when users request to reconfigure the link, and in that case, all request will be cancelled. Hence, it is not necessary to process the request. --- src/network/networkd-setlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/networkd-setlink.c b/src/network/networkd-setlink.c index a3b52dc8d24..47dc6720ac0 100644 --- a/src/network/networkd-setlink.c +++ b/src/network/networkd-setlink.c @@ -486,7 +486,7 @@ static int link_is_ready_to_set_link(Link *link, Request *req) { op = PTR_TO_INT(req->set_link_operation_ptr); - if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED)) + if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED)) return false; switch (op) { @@ -1017,7 +1017,7 @@ static int link_up_or_down(Link *link, bool up, Request *req) { static bool link_is_ready_to_activate(Link *link) { assert(link); - if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED)) + if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED)) return false; if (link->set_link_messages > 0) -- 2.47.3