From a6276f0f3fd8d92397883f4b849f536fd1c991a6 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Thu, 1 Nov 2018 23:24:17 +0900 Subject: [PATCH] network: fix memleak in routing policy As set_put() may fail if input is duplicated. --- src/network/networkd-routing-policy-rule.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/networkd-routing-policy-rule.c b/src/network/networkd-routing-policy-rule.c index 28a2a0fcbff..9ce3acd8076 100644 --- a/src/network/networkd-routing-policy-rule.c +++ b/src/network/networkd-routing-policy-rule.c @@ -257,8 +257,8 @@ static int routing_policy_rule_add_internal(Manager *m, rule->tos = tos; rule->fwmark = fwmark; rule->table = table; - rule->iif = TAKE_PTR(iif); - rule->oif = TAKE_PTR(oif); + rule->iif = iif; + rule->oif = oif; r = set_ensure_allocated(rules, &routing_policy_rule_hash_ops); if (r < 0) @@ -272,6 +272,7 @@ static int routing_policy_rule_add_internal(Manager *m, *ret = rule; rule = NULL; + iif = oif = NULL; return 0; } -- 2.47.3