From a684b82774556f3546123230ccdb95d528c41012 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Tue, 26 Nov 2019 15:16:53 -0800 Subject: [PATCH] util: isolated some dependencies from *.h to *.c so that they don't get transitively included into users of util.h. --- programs/util.c | 15 +++++++++++++++ programs/util.h | 16 +--------------- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/programs/util.c b/programs/util.c index 3c541c550..5354e864d 100644 --- a/programs/util.c +++ b/programs/util.c @@ -17,9 +17,24 @@ extern "C" { * Dependencies ******************************************/ #include "util.h" /* note : ensure that platform.h is included first ! */ +#include /* malloc, realloc, free */ +#include /* clock_t, clock, CLOCKS_PER_SEC, nanosleep */ #include #include +#if defined(_WIN32) +# include /* utime */ +# include /* _chmod */ +#else +# include /* chown, stat */ +# if PLATFORM_POSIX_VERSION < 200809L +# include /* utime */ +# else +# include /* AT_FDCWD */ +# include /* utimensat */ +# endif +#endif + #if defined(_MSC_VER) || defined(__MINGW32__) || defined (__MSVCRT__) #include /* needed for _mkdir in windows */ #endif diff --git a/programs/util.h b/programs/util.h index 27f5d5a0b..53431657d 100644 --- a/programs/util.h +++ b/programs/util.h @@ -20,25 +20,11 @@ extern "C" { * Dependencies ******************************************/ #include "platform.h" /* PLATFORM_POSIX_VERSION, ZSTD_NANOSLEEP_SUPPORT, ZSTD_SETPRIORITY_SUPPORT */ -#include /* malloc, realloc, free */ #include /* size_t, ptrdiff_t */ #include /* fprintf */ #include /* stat, utime */ #include /* stat, chmod */ -#if defined(_WIN32) -# include /* utime */ -# include /* _chmod */ -#else -# include /* chown, stat */ -# if PLATFORM_POSIX_VERSION < 200809L -# include /* utime */ -# else -# include /* AT_FDCWD */ -# include /* utimensat */ -# endif -#endif -#include /* clock_t, clock, CLOCKS_PER_SEC, nanosleep */ -#include "mem.h" /* U32, U64 */ +#include "mem.h" /* U64 */ /*-************************************************************ * Avoid fseek()'s 2GiB barrier with MSVC, macOS, *BSD, MinGW -- 2.47.2