From a6f3110318dda041461863d2830c3b356e7c6f0f Mon Sep 17 00:00:00 2001 From: Neil Horman Date: Wed, 29 Jan 2025 14:31:25 -0500 Subject: [PATCH] Move EAGAIN handling of QUIC retry/verneg frames to QUIC FUTURE MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes openssl/project#1072 Fixes openssl/project#1073 Reviewed-by: Matt Caswell Reviewed-by: Saša Nedvědický (Merged from https://github.com/openssl/openssl/pull/26593) --- ssl/quic/quic_port.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ssl/quic/quic_port.c b/ssl/quic/quic_port.c index a9ee31fbf9c..a56d119a12c 100644 --- a/ssl/quic/quic_port.c +++ b/ssl/quic/quic_port.c @@ -1142,7 +1142,7 @@ static void port_send_retry(QUIC_PORT *port, goto err; /* - * TODO(QUIC SERVER) need to retry this in the event it return EAGAIN + * TODO(QUIC FUTURE) need to retry this in the event it return EAGAIN * on a non-blocking BIO */ if (!BIO_sendmmsg(port->net_wbio, msg, sizeof(BIO_MSG), 1, 0, &written)) @@ -1234,7 +1234,7 @@ static void port_send_version_negotiation(QUIC_PORT *port, BIO_ADDR *peer, /* * Send it back to the client attempting to connect - * TODO(QUIC SERVER): Need to handle the EAGAIN case here, if the + * TODO(QUIC FUTURE): Need to handle the EAGAIN case here, if the * BIO_sendmmsg call falls in a retryable manner */ if (!BIO_sendmmsg(port->net_wbio, msg, sizeof(BIO_MSG), 1, 0, &written)) @@ -1506,7 +1506,7 @@ static void port_default_packet_handler(QUIC_URXE *e, void *arg, /* * If we don't get a supported version, respond with a ver * negotiation packet, and discard - * TODO(QUIC SERVER): Rate limit the reception of these + * TODO(QUIC FUTURE): Rate limit the reception of these */ port_send_version_negotiation(port, &e->peer, &hdr); goto undesirable; @@ -1522,7 +1522,7 @@ static void port_default_packet_handler(QUIC_URXE *e, void *arg, odcid.id_len = 0; /* - * TODO(QUIC SERVER): there should be some logic similar to accounting half-open + * TODO(QUIC FUTURE): there should be some logic similar to accounting half-open * states in TCP. If we reach certain threshold, then we want to * validate clients. */ -- 2.47.2