From a747fb49be395e9d70818d2ffc16b61796539af4 Mon Sep 17 00:00:00 2001
From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 2 May 2023 14:16:44 +0200
Subject: [PATCH] move assignment outside of condition

---
 modules/lmdbbackend/lmdbbackend.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 219521978f..55f3d6baa1 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1680,7 +1680,10 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
       DomainInfo di;
 
       // this get grabs the oldest item if there are duplicates
-      if (!(di.id = txn.get<0>(zone, di))) {
+      di.id = txn.get<0>(zone, di);
+
+      if (di.id == 0) {
+        // .get actually found nothing for us
         continue;
       }
 
-- 
2.47.2