From a7764ce79215c363228136b6c42ec9b203e10bbc Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Fri, 23 Feb 2018 14:21:51 +0100 Subject: [PATCH] lxccontainer: do_add_remove_node() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner --- src/lxc/lxccontainer.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 1d7bc7c43..3072b4c2d 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -4262,11 +4262,11 @@ static bool do_add_remove_node(pid_t init_pid, const char *path, bool add, ret = chroot(chrootpath); if (ret < 0) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); ret = chdir("/"); if (ret < 0) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); /* remove path if it exists */ ret = faccessat(AT_FDCWD, path, F_OK, AT_SYMLINK_NOFOLLOW); @@ -4274,24 +4274,24 @@ static bool do_add_remove_node(pid_t init_pid, const char *path, bool add, ret = unlink(path); if (ret < 0) { ERROR("%s - Failed to remove \"%s\"", strerror(errno), path); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } } if (!add) - exit(EXIT_SUCCESS); + _exit(EXIT_SUCCESS); /* create any missing directories */ tmp = strdup(path); if (!tmp) - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); directory_path = dirname(tmp); ret = mkdir_p(directory_path, 0755); if (ret < 0 && errno != EEXIST) { ERROR("%s - Failed to create path \"%s\"", strerror(errno), directory_path); free(tmp); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } /* create the device node */ @@ -4299,10 +4299,10 @@ static bool do_add_remove_node(pid_t init_pid, const char *path, bool add, free(tmp); if (ret < 0) { ERROR("%s - Failed to create device node at \"%s\"", strerror(errno), path); - exit(EXIT_FAILURE); + _exit(EXIT_FAILURE); } - exit(EXIT_SUCCESS); + _exit(EXIT_SUCCESS); } static bool add_remove_device_node(struct lxc_container *c, const char *src_path, const char *dest_path, bool add) -- 2.47.2