From a7cbd5f9a8e79741f33f6af9ff8a6d5610fa17c1 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Tue, 7 Feb 2023 19:15:45 +0000 Subject: [PATCH] arm: [MVE intrinsics] factorize several binary _m_n operations Factorize vhaddq_m_n, vhsubq_m_n, vmlaq_m_n, vmlasq_m_n, vqaddq_m_n, vqdmlahq_m_n, vqdmlashq_m_n, vqdmulhq_m_n, vqrdmlahq_m_n, vqrdmlashq_m_n, vqrdmulhq_m_n, vqsubq_m_n so that they use the same pattern. 2022-09-08 Christophe Lyon gcc/ * config/arm/iterators.md (MVE_INT_SU_M_N_BINARY): New. (mve_insn): Add vhaddq, vhsubq, vmlaq, vmlasq, vqaddq, vqdmlahq, vqdmlashq, vqdmulhq, vqrdmlahq, vqrdmlashq, vqrdmulhq, vqsubq. (supf): Add VQDMLAHQ_M_N_S, VQDMLASHQ_M_N_S, VQRDMLAHQ_M_N_S, VQRDMLASHQ_M_N_S, VQDMULHQ_M_N_S, VQRDMULHQ_M_N_S. * config/arm/mve.md (mve_vhaddq_m_n_) (mve_vhsubq_m_n_, mve_vmlaq_m_n_) (mve_vmlasq_m_n_, mve_vqaddq_m_n_) (mve_vqdmlahq_m_n_s, mve_vqdmlashq_m_n_s) (mve_vqrdmlahq_m_n_s, mve_vqrdmlashq_m_n_s) (mve_vqsubq_m_n_, mve_vqdmulhq_m_n_s) (mve_vqrdmulhq_m_n_s): Merge into ... (@mve_q_m_n_): ... this. --- gcc/config/arm/iterators.md | 33 ++++++ gcc/config/arm/mve.md | 206 +++--------------------------------- 2 files changed, 48 insertions(+), 191 deletions(-) diff --git a/gcc/config/arm/iterators.md b/gcc/config/arm/iterators.md index af9860f47e9d..afb491e8d953 100644 --- a/gcc/config/arm/iterators.md +++ b/gcc/config/arm/iterators.md @@ -384,6 +384,21 @@ VORRQ_M_N_S VORRQ_M_N_U ]) +(define_int_iterator MVE_INT_SU_M_N_BINARY [ + VHADDQ_M_N_S VHADDQ_M_N_U + VHSUBQ_M_N_S VHSUBQ_M_N_U + VMLAQ_M_N_S VMLAQ_M_N_U + VMLASQ_M_N_S VMLASQ_M_N_U + VQDMLAHQ_M_N_S + VQDMLASHQ_M_N_S + VQRDMLAHQ_M_N_S + VQRDMLASHQ_M_N_S + VQADDQ_M_N_S VQADDQ_M_N_U + VQSUBQ_M_N_S VQSUBQ_M_N_U + VQDMULHQ_M_N_S + VQRDMULHQ_M_N_S + ]) + (define_int_iterator MVE_INT_N_BINARY [ VADDQ_N_S VADDQ_N_U VMULQ_N_S VMULQ_N_U @@ -450,12 +465,16 @@ (VBICQ_N_S "vbic") (VBICQ_N_U "vbic") (VCREATEQ_S "vcreate") (VCREATEQ_U "vcreate") (VCREATEQ_F "vcreate") (VEORQ_M_S "veor") (VEORQ_M_U "veor") (VEORQ_M_F "veor") + (VHADDQ_M_N_S "vhadd") (VHADDQ_M_N_U "vhadd") (VHADDQ_M_S "vhadd") (VHADDQ_M_U "vhadd") (VHADDQ_N_S "vhadd") (VHADDQ_N_U "vhadd") + (VHSUBQ_M_N_S "vhsub") (VHSUBQ_M_N_U "vhsub") (VHSUBQ_M_S "vhsub") (VHSUBQ_M_U "vhsub") (VHSUBQ_N_S "vhsub") (VHSUBQ_N_U "vhsub") (VMAXQ_M_S "vmax") (VMAXQ_M_U "vmax") (VMINQ_M_S "vmin") (VMINQ_M_U "vmin") + (VMLAQ_M_N_S "vmla") (VMLAQ_M_N_U "vmla") + (VMLASQ_M_N_S "vmlas") (VMLASQ_M_N_U "vmlas") (VMULHQ_M_S "vmulh") (VMULHQ_M_U "vmulh") (VMULQ_M_N_S "vmul") (VMULQ_M_N_U "vmul") (VMULQ_M_N_F "vmul") (VMULQ_M_S "vmul") (VMULQ_M_U "vmul") (VMULQ_M_F "vmul") @@ -463,22 +482,30 @@ (VORRQ_M_N_S "vorr") (VORRQ_M_N_U "vorr") (VORRQ_M_S "vorr") (VORRQ_M_U "vorr") (VORRQ_M_F "vorr") (VORRQ_N_S "vorr") (VORRQ_N_U "vorr") + (VQADDQ_M_N_S "vqadd") (VQADDQ_M_N_U "vqadd") (VQADDQ_M_S "vqadd") (VQADDQ_M_U "vqadd") (VQADDQ_N_S "vqadd") (VQADDQ_N_U "vqadd") (VQDMLADHQ_M_S "vqdmladh") (VQDMLADHXQ_M_S "vqdmladhx") + (VQDMLAHQ_M_N_S "vqdmlah") + (VQDMLASHQ_M_N_S "vqdmlash") (VQDMLSDHQ_M_S "vqdmlsdh") (VQDMLSDHXQ_M_S "vqdmlsdhx") + (VQDMULHQ_M_N_S "vqdmulh") (VQDMULHQ_M_S "vqdmulh") (VQDMULHQ_N_S "vqdmulh") (VQRDMLADHQ_M_S "vqrdmladh") (VQRDMLADHXQ_M_S "vqrdmladhx") + (VQRDMLAHQ_M_N_S "vqrdmlah") + (VQRDMLASHQ_M_N_S "vqrdmlash") (VQRDMLSDHQ_M_S "vqrdmlsdh") (VQRDMLSDHXQ_M_S "vqrdmlsdhx") + (VQRDMULHQ_M_N_S "vqrdmulh") (VQRDMULHQ_M_S "vqrdmulh") (VQRDMULHQ_N_S "vqrdmulh") (VQRSHLQ_M_S "vqrshl") (VQRSHLQ_M_U "vqrshl") (VQSHLQ_M_S "vqshl") (VQSHLQ_M_U "vqshl") + (VQSUBQ_M_N_S "vqsub") (VQSUBQ_M_N_U "vqsub") (VQSUBQ_M_S "vqsub") (VQSUBQ_M_U "vqsub") (VQSUBQ_N_S "vqsub") (VQSUBQ_N_U "vqsub") (VRHADDQ_M_S "vrhadd") (VRHADDQ_M_U "vrhadd") @@ -1636,6 +1663,12 @@ (VQRDMULHQ_M_S "s") (VQDMULHQ_N_S "s") (VQRDMULHQ_N_S "s") + (VQDMLAHQ_M_N_S "s") + (VQDMLASHQ_M_N_S "s") + (VQRDMLAHQ_M_N_S "s") + (VQRDMLASHQ_M_N_S "s") + (VQDMULHQ_M_N_S "s") + (VQRDMULHQ_M_N_S "s") ]) ;; Both kinds of return insn. diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md index 11c2b6343d7c..27439bbd3cb9 100644 --- a/gcc/config/arm/mve.md +++ b/gcc/config/arm/mve.md @@ -4981,36 +4981,30 @@ (set_attr "length""8")]) ;; -;; [vhaddq_m_n_s, vhaddq_m_n_u]) +;; [vhaddq_m_n_s, vhaddq_m_n_u] +;; [vhsubq_m_n_s, vhsubq_m_n_u] +;; [vmlaq_m_n_s, vmlaq_m_n_u] +;; [vmlasq_m_n_u, vmlasq_m_n_s] +;; [vqaddq_m_n_u, vqaddq_m_n_s] +;; [vqdmlahq_m_n_s] +;; [vqdmlashq_m_n_s] +;; [vqdmulhq_m_n_s] +;; [vqrdmlahq_m_n_s] +;; [vqrdmlashq_m_n_s] +;; [vqrdmulhq_m_n_s] +;; [vqsubq_m_n_u, vqsubq_m_n_s] ;; -(define_insn "mve_vhaddq_m_n_" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VHADDQ_M_N)) - ] - "TARGET_HAVE_MVE" - "vpst\;vhaddt.%# %q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vhsubq_m_n_s, vhsubq_m_n_u]) -;; -(define_insn "mve_vhsubq_m_n_" +(define_insn "@mve_q_m_n_" [ (set (match_operand:MVE_2 0 "s_register_operand" "=w") (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") (match_operand:MVE_2 2 "s_register_operand" "w") (match_operand: 3 "s_register_operand" "r") (match_operand: 4 "vpr_register_operand" "Up")] - VHSUBQ_M_N)) + MVE_INT_SU_M_N_BINARY)) ] "TARGET_HAVE_MVE" - "vpst\;vhsubt.%# %q0, %q2, %3" + "vpst\;t.%#\t%q0, %q2, %3" [(set_attr "type" "mve_move") (set_attr "length""8")]) @@ -5032,40 +5026,6 @@ [(set_attr "type" "mve_move") (set_attr "length""8")]) -;; -;; [vmlaq_m_n_s, vmlaq_m_n_u]) -;; -(define_insn "mve_vmlaq_m_n_" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VMLAQ_M_N)) - ] - "TARGET_HAVE_MVE" - "vpst\;vmlat.%# %q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vmlasq_m_n_u, vmlasq_m_n_s]) -;; -(define_insn "mve_vmlasq_m_n_" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VMLASQ_M_N)) - ] - "TARGET_HAVE_MVE" - "vpst\;vmlast.%# %q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - ;; ;; [vmullbq_int_m_u, vmullbq_int_m_s]) ;; @@ -5117,91 +5077,6 @@ [(set_attr "type" "mve_move") (set_attr "length""8")]) -;; -;; [vqaddq_m_n_u, vqaddq_m_n_s]) -;; -(define_insn "mve_vqaddq_m_n_" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQADDQ_M_N)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqaddt.%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vqdmlahq_m_n_s]) -;; -(define_insn "mve_vqdmlahq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQDMLAHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqdmlaht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vqdmlashq_m_n_s]) -;; -(define_insn "mve_vqdmlashq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQDMLASHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqdmlasht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vqrdmlahq_m_n_s]) -;; -(define_insn "mve_vqrdmlahq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQRDMLAHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqrdmlaht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vqrdmlashq_m_n_s]) -;; -(define_insn "mve_vqrdmlashq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQRDMLASHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqrdmlasht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - ;; ;; [vqshlq_m_n_s, vqshlq_m_n_u]) ;; @@ -5219,23 +5094,6 @@ [(set_attr "type" "mve_move") (set_attr "length""8")]) -;; -;; [vqsubq_m_n_u, vqsubq_m_n_s]) -;; -(define_insn "mve_vqsubq_m_n_" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQSUBQ_M_N)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqsubt.%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - ;; ;; [vrshrq_m_n_s, vrshrq_m_n_u]) ;; @@ -5389,40 +5247,6 @@ [(set_attr "type" "mve_move") (set_attr "length""8")]) -;; -;; [vqdmulhq_m_n_s]) -;; -(define_insn "mve_vqdmulhq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQDMULHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqdmulht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - -;; -;; [vqrdmulhq_m_n_s]) -;; -(define_insn "mve_vqrdmulhq_m_n_s" - [ - (set (match_operand:MVE_2 0 "s_register_operand" "=w") - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" "0") - (match_operand:MVE_2 2 "s_register_operand" "w") - (match_operand: 3 "s_register_operand" "r") - (match_operand: 4 "vpr_register_operand" "Up")] - VQRDMULHQ_M_N_S)) - ] - "TARGET_HAVE_MVE" - "vpst\;vqrdmulht.s%#\t%q0, %q2, %3" - [(set_attr "type" "mve_move") - (set_attr "length""8")]) - ;; ;; [vmlaldavaq_p_u, vmlaldavaq_p_s]) ;; -- 2.47.2