From a8a75b667520c72c45b032bf42b8905cb276ee3c Mon Sep 17 00:00:00 2001 From: Christian Goeschel Ndjomouo Date: Tue, 2 Dec 2025 00:50:28 -0500 Subject: [PATCH] unshare: use MAX_OF_UINT_TYPE instead of (type)-1 Signed-off-by: Christian Goeschel Ndjomouo --- sys-utils/unshare.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys-utils/unshare.c b/sys-utils/unshare.c index 0671ed3e1..3cec3be82 100644 --- a/sys-utils/unshare.c +++ b/sys-utils/unshare.c @@ -1190,14 +1190,14 @@ int main(int argc, char *argv[]) #endif } - if (mapuser != (uid_t) -1 && !usermap) + if (mapuser != MAX_OF_UINT_TYPE(uid_t) && !usermap) map_id(_PATH_PROC_UIDMAP, mapuser, real_euid); /* Since Linux 3.19 unprivileged writing of /proc/self/gid_map * has been disabled unless /proc/self/setgroups is written * first to permanently disable the ability to call setgroups * in that user namespace. */ - if (mapgroup != (gid_t) -1 && !groupmap) { + if (mapgroup != MAX_OF_UINT_TYPE(gid_t) && !groupmap) { if (setgrpcmd == SETGROUPS_ALLOW) errx(EXIT_FAILURE, _("options --setgroups=allow and " "--map-group are mutually exclusive")); -- 2.47.3