From a8bfb4d13579b9f7d546261938b452fd9f875d0b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim=20D=C3=BCsterhus?= Date: Sat, 11 Sep 2021 17:02:33 +0200 Subject: [PATCH] CLEANUP: ebmbtree: Replace always-taken elseif by else `diff` is guaranteed to be less than 0, because the `if` handles the `>= 0` case. Found using GitHub's CodeQL scan in HAProxy's codebase. --- include/import/ebmbtree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/import/ebmbtree.h b/include/import/ebmbtree.h index f99c16ba9a..1a45426247 100644 --- a/include/import/ebmbtree.h +++ b/include/import/ebmbtree.h @@ -358,7 +358,7 @@ __ebmb_insert(struct eb_root *root, struct ebmb_node *new, unsigned int len) new->node.leaf_p = new_rght; *up_ptr = new_left; } - else if (diff < 0) { + else { new->node.branches.b[EB_LEFT] = new_leaf; new->node.branches.b[EB_RGHT] = troot; new->node.leaf_p = new_left; -- 2.47.2