From a8c9b49747c0ece94da0c9a87a0e0575fb66f9a6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Tue, 6 Apr 2021 12:00:00 +0100 Subject: [PATCH] tests: add warning that qemucapsprobe prefers native host/guest arch MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Generally we want the QEMU capabilities data in git to report KVM related features, and thus we strongly prefer that the capabilities are generated on a native host. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- tests/qemucapsprobe.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/qemucapsprobe.c b/tests/qemucapsprobe.c index 26ea9ff5ed..a89d9c8feb 100644 --- a/tests/qemucapsprobe.c +++ b/tests/qemucapsprobe.c @@ -46,6 +46,8 @@ main(int argc, char **argv) { virThread thread; virQEMUCapsPtr caps; + virArch host; + virArch guest; const char *mock = VIR_TEST_MOCK("qemucapsprobe"); if (!virFileIsExecutable(mock)) { @@ -80,6 +82,18 @@ main(int argc, char **argv) -1, -1, NULL, 0, NULL))) return EXIT_FAILURE; + host = virArchFromHost(); + guest = virQEMUCapsGetArch(caps); + + if (host != guest) { + fprintf(stderr, + "WARNING: guest architecture '%s' does not match host '%s'.\n" + "WARNING: When generating capabilities for the libvirt test\n" + "WARNING: suite, it is strongly desired to generate capabilities\n" + "WARNING: on the native host to capture KVM related features.\n", + virArchToString(guest), virArchToString(host)); + } + virObjectUnref(caps); return EXIT_SUCCESS; -- 2.47.2