From a8cf5c1bee0fe1b3a829118d636d4f1ea6b408b0 Mon Sep 17 00:00:00 2001 From: John Garry Date: Thu, 13 Nov 2025 13:36:42 +0000 Subject: [PATCH] scsi: scsi_debug: Drop NULL scsi_cmnd check in sdebug_q_cmd_complete() The scp pointer cannot be NULL, as it is evaluated from container_of() and pointer offsets (so remove the check in sdebug_q_cmd_complete()). Signed-off-by: John Garry Link: https://patch.msgid.link/20251113133645.2898748-4-john.g.garry@oracle.com Signed-off-by: Martin K. Petersen --- drivers/scsi/scsi_debug.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index cbe15a76a98bd..9f17e9c49cb5d 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -6396,11 +6396,6 @@ static void sdebug_q_cmd_complete(struct sdebug_defer *sd_dp) atomic_inc(&sdebug_miss_cpus); } - if (!scp) { - pr_err("scmd=NULL\n"); - return; - } - spin_lock_irqsave(&sdsc->lock, flags); aborted = sd_dp->aborted; if (unlikely(aborted)) -- 2.47.3