From a8ed27e70a006083c528b2571bbbc0afa80fb5f4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Thu, 18 Feb 2021 14:16:36 +0100 Subject: [PATCH] qemu: saveimage: only steal domXML on success MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The comment and the caller assume virQEMUSaveDataNew only steals domXML on success, but it is copied even on failure. Also remove the misleading g_steal_pointer call on a local variable. Reported by coverity. Signed-off-by: Ján Tomko Reviewed-by: Erik Skultety --- src/qemu/qemu_saveimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index de2d63dd9a..5d542bf977 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -105,8 +105,6 @@ virQEMUSaveDataNew(char *domXML, data = g_new0(virQEMUSaveData, 1); - data->xml = g_steal_pointer(&domXML); - if (cookieObj && !(data->cookie = virSaveCookieFormat((virObjectPtr) cookieObj, virDomainXMLOptionGetSaveCookie(xmlopt)))) @@ -118,6 +116,7 @@ virQEMUSaveDataNew(char *domXML, header->was_running = running ? 1 : 0; header->compressed = compressed; + data->xml = domXML; return data; error: -- 2.47.2