From a93b6bb3a2e50528fa20056c2fba33cbd9cf2ec7 Mon Sep 17 00:00:00 2001 From: Roi Dayan Date: Sun, 27 Nov 2016 13:21:02 +0200 Subject: [PATCH] devlink: Add usage help for eswitch subcommand Add missing usage help for devlink dev eswitch subcommand. Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz --- devlink/devlink.c | 7 ++++++- man/man8/devlink-dev.8 | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index ccca0fb39..673234fa7 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -963,6 +963,8 @@ static bool dl_dump_filter(struct dl *dl, struct nlattr **tb) static void cmd_dev_help(void) { pr_err("Usage: devlink dev show [ DEV ]\n"); + pr_err(" devlink dev eswitch set DEV [ mode { legacy | switchdev } ]\n"); + pr_err(" devlink dev eswitch show DEV\n"); } static bool cmp_arr_last_handle(struct dl *dl, const char *bus_name, @@ -1259,7 +1261,10 @@ static int cmd_dev_eswitch_set(struct dl *dl) static int cmd_dev_eswitch(struct dl *dl) { - if (dl_argv_match(dl, "set")) { + if (dl_argv_match(dl, "help") || dl_no_arg(dl)) { + cmd_dev_help(); + return 0; + } else if (dl_argv_match(dl, "set")) { dl_arg_inc(dl); return cmd_dev_eswitch_set(dl); } else if (dl_argv_match(dl, "show")) { diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 index 9ce319374..931e334da 100644 --- a/man/man8/devlink-dev.8 +++ b/man/man8/devlink-dev.8 @@ -54,7 +54,7 @@ BUS_NAME/BUS_ADDRESS .TP .BR mode " { " legacy " | " switchdev " } " -set eswitch mode +Set eswitch mode .I legacy - Legacy SRIOV -- 2.47.2