From a93ea4cd84da622604a133c92daa6c7d6238c781 Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Thu, 6 Mar 2025 12:00:13 +0100 Subject: [PATCH] domain_conf: graphics: extract Desktop formatting to separate function MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko --- src/conf/domain_conf.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3587abc24a..c66cdfc1a2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26531,6 +26531,16 @@ virDomainGraphicsDefFormatRDP(virBuffer *attrBuf, virDomainGraphicsListenDefFormatAddr(attrBuf, glisten, flags); } +static void +virDomainGraphicsDefFormatDesktop(virBuffer *attrBuf, + virDomainGraphicsDef *def) +{ + virBufferEscapeString(attrBuf, " display='%s'", def->data.desktop.display); + + if (def->data.desktop.fullscreen) + virBufferAddLit(attrBuf, " fullscreen='yes'"); +} + static int virDomainGraphicsDefFormat(virBuffer *buf, virDomainGraphicsDef *def, @@ -26565,12 +26575,7 @@ virDomainGraphicsDefFormat(virBuffer *buf, break; case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: - virBufferEscapeString(&attrBuf, " display='%s'", - def->data.desktop.display); - - if (def->data.desktop.fullscreen) - virBufferAddLit(&attrBuf, " fullscreen='yes'"); - + virDomainGraphicsDefFormatDesktop(&attrBuf, def); break; case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: -- 2.47.3