From a95c1911d8e8fd0c76fc67232ebc1176162ec8d7 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 16 Jul 2024 17:09:38 +0200 Subject: [PATCH] libgomp: Document 'GOMP_teams4' For reference: - "[PATCH] openmp: Honor OpenMP 5.1 num_teams lower bound" - "[PATCH] libgomp, nvptx: Honor OpenMP 5.1 num_teams lower bound" libgomp/ * config/gcn/target.c (GOMP_teams4): Document. * config/nvptx/target.c (GOMP_teams4): Likewise. * target.c (GOMP_teams4): Likewise. --- libgomp/config/gcn/target.c | 8 ++++++++ libgomp/config/nvptx/target.c | 8 ++++++++ libgomp/target.c | 9 +++++++++ 3 files changed, 25 insertions(+) diff --git a/libgomp/config/gcn/target.c b/libgomp/config/gcn/target.c index e57d2e5f93f..9cafea4e2cc 100644 --- a/libgomp/config/gcn/target.c +++ b/libgomp/config/gcn/target.c @@ -29,6 +29,14 @@ extern volatile struct gomp_offload_icvs GOMP_ADDITIONAL_ICVS; +/* Implement OpenMP 'teams' construct. + + Initialize upon FIRST call. Return whether this invocation is active. + Depending on whether NUM_TEAMS_LOWER asks for more teams than are provided + in hardware, we may need to loop multiple times; in that case make sure to + update the team-level variable used by 'omp_get_team_num', as we then can't + just use '__builtin_gcn_dim_pos (0)'. */ + bool GOMP_teams4 (unsigned int num_teams_lower, unsigned int num_teams_upper, unsigned int thread_limit, bool first) diff --git a/libgomp/config/nvptx/target.c b/libgomp/config/nvptx/target.c index f14dcfc8ff6..8d4dc5f661a 100644 --- a/libgomp/config/nvptx/target.c +++ b/libgomp/config/nvptx/target.c @@ -31,6 +31,14 @@ extern int __gomp_team_num __attribute__((shared)); extern volatile struct gomp_offload_icvs GOMP_ADDITIONAL_ICVS; volatile struct rev_offload *GOMP_REV_OFFLOAD_VAR; +/* Implement OpenMP 'teams' construct. + + Initialize upon FIRST call. Return whether this invocation is active. + Depending on whether NUM_TEAMS_LOWER asks for more teams than are provided + in hardware, we may need to loop multiple times; in that case make sure to + update the team-level variable used by 'omp_get_team_num', as we then can't + just use '%ctaid.x'. */ + bool GOMP_teams4 (unsigned int num_teams_lower, unsigned int num_teams_upper, unsigned int thread_limit, bool first) diff --git a/libgomp/target.c b/libgomp/target.c index 48689920d4a..aa01c1367b9 100644 --- a/libgomp/target.c +++ b/libgomp/target.c @@ -4352,6 +4352,8 @@ gomp_target_task_fn (void *data) return false; } +/* Implement OpenMP 'teams' construct, legacy entry point. */ + void GOMP_teams (unsigned int num_teams, unsigned int thread_limit) { @@ -4364,6 +4366,13 @@ GOMP_teams (unsigned int num_teams, unsigned int thread_limit) (void) num_teams; } +/* Implement OpenMP 'teams' construct. + + Initialize upon FIRST call. Return whether this invocation is active. + Depending on whether NUM_TEAMS_LOW asks for more teams than are provided + in hardware, we may need to loop multiple times; in that case make sure to + update the team-level variable used by 'omp_get_team_num'. */ + bool GOMP_teams4 (unsigned int num_teams_low, unsigned int num_teams_high, unsigned int thread_limit, bool first) -- 2.47.2